android support (tested with yadaw)#174
Conversation
Boddlnagg
left a comment
Boddlnagg
left a comment
There was a problem hiding this comment.
Thank you for this PR! Android support is very valuable for this project, and something I would never have found time to work on myself :-)
I'm not really able to review this in-depth or test this (I have never done any Android development), but I trust that you have tested it.
It would be great if you could find some way to test/build this on CI ... is there any way to achieve that (either through the existing Azure Pipelines, or with GitHub Actions)?
Actually had looked at #77 previously, was interested in trying to migrate it to gh actions for the current ones (am familiar with it too). Might just open another pr or commit the yml changes here soon.. |
mlm-games
force-pushed
the
android-support
branch
2 times, most recently
from
937cb72 to
afb416e
Compare
|
Thanks for your work on the GH actions migration! |
|
Yep, its ready to be reviewed |
|
Is it too much to ask that you extract the migration to GitHub Actions into a separate PR, which can be merged first independently? |
|
Oh, thought it wasn't asked before, will do it by tomorrow. |
mlm-games
force-pushed
the
android-support
branch
from
6fa31aa to
111f9b4
Compare
|
Done |
|
You can now rebase on top of |
mlm-games
force-pushed
the
android-support
branch
from
b5cdcb7 to
b5f07e0
Compare
done |
2 participants
Adds android support, tested using yadaw
More info (pasted from readme)
cargo install cargo-ndkrustup target add aarch64-linux-androidcargo ndk -t arm64-v8a -o ./app/src/main/jniLibs build --release<uses-feature android:name="android.software.midi" android:required="false" />(not needed for USB/BLE MIDI).